DanS
798eccc624
Phase 1 of the code-hygiene remediation. Each is a genuine defect, not
style. The two consensus functions are touched only by provably
behavior-preserving dead-code removal and a comment.
- miner: initialize the anti-spin loop counter (was `int i;` -- the loop
condition read an indeterminate value, UB) and break once the block
time advances past the median, which is what the comment intended.
- consensus/upgrades: drop a stray printf() on the NetworkUpgradeState
path; the following assert already documents the invariant.
- txdb: CBlockTreeDB::Snapshot2's outer catch treated ANY exception as
normal end-of-iteration and built a snapshot from partial data. Fail
instead, matching the inner catch the author marked consensus-relevant
("we need to exit here if so for consensus code!"). iter->Valid()
already handles genuine end-of-iteration.
- wallet/rpcwallet + init: -sietch-min-zouts used a "--" key that the arg
parser (which normalizes --foo to -foo) can never match, so the Sietch
decoy floor was silently stuck at the default. Use the single-dash key
so the knob works, and document it in -help.
- hush_bitcoind + hush_utils: remove four unreachable duplicate `else if`
branches from hush_commission()/hush_block_subsidy() (a second
`height < 23860000` and a second `height < 27220000` in each). Proven
identical across 49,591 heights. NB: the dead values hint at an intended
clean halving schedule that was never wired up; the DEPLOYED schedule
(two double-steps) is preserved exactly. Changing it is a future
consensus decision, not this cleanup.
- hush_bitcoind: replace the "likely a bug" halving TODO with an accurate
note -- INTERVAL is only consumed by a debug fprintf, so the > vs >=
boundary at HALVING1 has no consensus effect.
- git rm two committed macOS build artifacts (cc/customcc.dylib and
libcc.dylib) and add the missing .dylib .gitignore rules.
Built clean on Linux; an isolated node self-mined genesis->5113 exercising
the miner and consensus-subsidy paths, and getsnapshot returned normally.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
180 lines
2.2 KiB
Plaintext
180 lines
2.2 KiB
Plaintext
*.tar.gz
|
|
*.deb
|
|
src/bitcoin
|
|
src/test/test_bitcoin
|
|
src/core
|
|
test-*.txt
|
|
|
|
*zcashTest.pk
|
|
*zcashTest.vk
|
|
|
|
# autoreconf
|
|
#Makefile.in
|
|
aclocal.m4
|
|
autom4te.cache/
|
|
build-aux/config.guess
|
|
build-aux/config.sub
|
|
build-aux/depcomp
|
|
build-aux/install-sh
|
|
build-aux/ltmain.sh
|
|
build-aux/m4/libtool.m4
|
|
build-aux/m4/lt~obsolete.m4
|
|
build-aux/m4/ltoptions.m4
|
|
build-aux/m4/ltsugar.m4
|
|
build-aux/m4/ltversion.m4
|
|
build-aux/missing
|
|
build-aux/compile
|
|
build-aux/test-driver
|
|
config.log
|
|
config.status
|
|
configure
|
|
configure~
|
|
libtool
|
|
src/config/bitcoin-config.h
|
|
src/config/bitcoin-config.h.in
|
|
src/config/stamp-h1
|
|
|
|
cache/
|
|
venv-mnf/
|
|
src/univalue/gen
|
|
|
|
.deps
|
|
.dirstamp
|
|
.idea
|
|
.libs
|
|
.*.sw?
|
|
*.*~*
|
|
*.bak
|
|
*.rej
|
|
*.orig
|
|
*.pyc
|
|
*.o
|
|
*.o-*
|
|
.zcash
|
|
*.a
|
|
*.pb.cc
|
|
*.pb.h
|
|
.vscode
|
|
|
|
*.log
|
|
*.trs
|
|
*.dmg
|
|
|
|
*.json.h
|
|
*.raw.h
|
|
|
|
#libtool object files
|
|
*.lo
|
|
*.la
|
|
|
|
# Compilation
|
|
Makefile
|
|
|
|
# Unit-tests
|
|
Makefile.test
|
|
src/test/buildenv.py
|
|
|
|
# Resources cpp
|
|
qrc_*.cpp
|
|
|
|
# Mac specific
|
|
.DS_Store
|
|
build
|
|
|
|
#lcov
|
|
*.gcno
|
|
*.gcda
|
|
/*.info
|
|
test_bitcoin.coverage/
|
|
zcash-gtest.coverage/
|
|
total.coverage/
|
|
coverage_percent.txt
|
|
|
|
#build tests
|
|
linux-coverage-build
|
|
linux-build
|
|
win32-build
|
|
qa/pull-tester/run-bitcoind-for-test.sh
|
|
qa/pull-tester/tests-config.sh
|
|
qa/pull-tester/cache/*
|
|
qa/pull-tester/test.*/*
|
|
|
|
!src/leveldb*/Makefile
|
|
|
|
/doc/doxygen/
|
|
|
|
libzcashconsensus.pc
|
|
|
|
src/fiat/-usd
|
|
contrib/debian/files
|
|
contrib/debian/substvars
|
|
|
|
src/rpcmisc~.cpp
|
|
src/wallet-utility
|
|
|
|
src/hush-cli
|
|
src/hushd
|
|
src/hush-tx
|
|
src/hush-test
|
|
src/hush-cli.exe
|
|
src/hushd.exe
|
|
src/hush-tx.exe
|
|
|
|
#output during builds, symbol tables?
|
|
*.dSYM
|
|
|
|
|
|
src/cryptoconditions/compile
|
|
|
|
src/cc/rogue/rogue
|
|
|
|
src/cc/rogue/rogue.so
|
|
|
|
src/cc/rogue/test.zip
|
|
src/cc/dapps/a.out
|
|
src/checkfile
|
|
|
|
src/foo.zip
|
|
|
|
src/log
|
|
|
|
src/rogue.530623577502174316.0
|
|
|
|
src/rogue.530623577502174316.pack
|
|
|
|
src/rogue.530623577502174316.player
|
|
|
|
|
|
src/cc/rogue/config.h
|
|
|
|
src/ROGUE.conf
|
|
|
|
src/rogue.scr
|
|
|
|
src/cc/rogue/confdefs.h
|
|
src/cc/rogue/x64
|
|
|
|
src/cc/dapps/a.out
|
|
src/Makefile.in
|
|
doc/man/Makefile.in
|
|
Makefile.in
|
|
src/libcc.so
|
|
src/libcc.dll
|
|
src/libcc.dylib
|
|
src/cc/customcc.so
|
|
src/cc/customcc.dll
|
|
src/cc/customcc.dylib
|
|
src/HUSH3_7776
|
|
REGTEST_7776
|
|
src/cc/librogue.so
|
|
src/cc/games/prices
|
|
src/cc/games/tetris
|
|
release-linux/
|
|
release/
|
|
src/dragonxd
|
|
src/dragonx-cli
|
|
src/dragonx-tx
|
|
src/dragonxd.exe
|
|
src/dragonx-cli.exe
|
|
src/dragonx-tx.exe
|
|
doc/relnotes/ |