Merge pull request #85 from DenioD/duke

port z_listsentbyaddress and add memo field from c00e30b210

src/Makefile.am

@@ -236,6 +236,7 @@ BITCOIN_CORE_H = \
   wallet/crypter.h \
   wallet/db.h \
   wallet/rpcwallet.h \
+  wallet/rpchushwallet.h \
   wallet/wallet.h \
   wallet/wallet_ismine.h \
   wallet/walletdb.h \
@@ -366,6 +367,7 @@ libbitcoin_wallet_a_SOURCES = \
   cc/CCassetstx.cpp \
   cc/CCtx.cpp \
   wallet/rpcwallet.cpp \
+  wallet/rpchushwallet.cpp \
   wallet/wallet.cpp \
   wallet/wallet_ismine.cpp \
   wallet/walletdb.cpp \

src/rpc/client.cpp

@@ -170,6 +170,11 @@ static const CRPCConvertParam vRPCConvertParams[] =
     { "z_importviewingkey", 2 },
     { "z_getpaymentdisclosure", 1},
     { "z_getpaymentdisclosure", 2},
+    { "z_listsentbyaddress", 1},
+    { "z_listsentbyaddress", 2},
+    { "z_listsentbyaddress", 3},
+    { "z_listsentbyaddress", 4},
+    { "z_listsentbyaddress", 5},
     // crosschain
     { "assetchainproof", 1},
     { "crosschainproof", 1},

src/rpc/register.h

@@ -34,6 +34,8 @@ void RegisterMiscRPCCommands(CRPCTable &tableRPC);
 void RegisterMiningRPCCommands(CRPCTable &tableRPC);
 /** Register raw transaction RPC commands */
 void RegisterRawTransactionRPCCommands(CRPCTable &tableRPC);
+/** Register Experimental RPC commands */
+void RegisterHushExclusiveRPCCommands(CRPCTable &tableRPC);
 
 /** Register test transaction RPC commands */
 void RegisterTesttransactionsRPCCommands(CRPCTable &tableRPC);
@@ -46,6 +48,7 @@ static inline void RegisterAllCoreRPCCommands(CRPCTable &tableRPC)
     RegisterMiscRPCCommands(tableRPC);
     RegisterMiningRPCCommands(tableRPC);
     RegisterRawTransactionRPCCommands(tableRPC);
+    RegisterHushExclusiveRPCCommands(tableRPC);
 #ifdef TESTMODE
     RegisterTesttransactionsRPCCommands(tableRPC);
 #endif

src/wallet/rpchushwallet.cpp

@@ -0,0 +1,537 @@
+// Copyright (c) 2020 The Hush developers
+// Copyright (c) 2019 Cryptoforge
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+#include "init.h"
+#include "key_io.h"
+#include "rpc/server.h"
+#include "wallet.h"
+#include "rpchushwallet.h"
+#include "utilmoneystr.h"
+#include <utf8.h>
+
+using namespace std;
+using namespace libzcash;
+
+bool EnsureWalletIsAvailable(bool avoidException);
+
+void zsTxSpendsToJSON(const CWalletTx& wtx, UniValue& spends, CAmount& totalSpends, CAmount& filteredSpends, const std::string& strAddress, bool filterByAddress) {
+
+  LOCK2(cs_main, pwalletMain->cs_wallet);
+
+  //Used to identify incomplete key sets
+  int vinCount = 0;
+  int vinSpendCount = 0;
+  int shieldedSpendCount = 0;
+  int shieldedSpendsSpentCount = 0;
+
+  //Check address
+  bool isTAddress = false;
+  bool isZsAddress = false;
+
+  CTxDestination tAddress = DecodeDestination(strAddress);
+  auto zAddress = DecodePaymentAddress(strAddress);
+  SaplingPaymentAddress zsAddress;
+
+  if (filterByAddress) {
+
+    if (IsValidDestination(tAddress))
+      isTAddress = true;
+
+    if (IsValidPaymentAddress(zAddress)) {
+      if (boost::get<libzcash::SaplingPaymentAddress>(&zAddress) != nullptr) {
+          zsAddress = boost::get<libzcash::SaplingPaymentAddress>(zAddress);
+          isZsAddress = true;
+      }
+    }
+  }
+
+
+  // Transparent Inputs belonging to the wallet
+  UniValue tSpends(UniValue::VARR);
+  if (isTAddress || !filterByAddress) {
+    for (int i = 0; i < wtx.vin.size(); i++) {
+      vinCount++;
+      const CTxIn& txin = wtx.vin[i];
+      UniValue obj(UniValue::VOBJ);
+      CTxDestination address;
+      const CWalletTx* parent = pwalletMain->GetWalletTx(txin.prevout.hash);
+      if (parent != NULL) {
+        const CTxOut& parentOut = parent->vout[txin.prevout.n];
+        ExtractDestination(parentOut.scriptPubKey, address);
+        if(IsMine(*pwalletMain, address)){
+          vinSpendCount++;
+          totalSpends += CAmount(-parentOut.nValue);
+          obj.push_back(Pair("address",EncodeDestination(address)));
+          obj.push_back(Pair("scriptPubKey",HexStr(parentOut.scriptPubKey.begin(), parentOut.scriptPubKey.end())));
+          obj.push_back(Pair("amount",ValueFromAmount(-parentOut.nValue)));
+          obj.push_back(Pair("spendTxid",parent->GetHash().ToString()));
+          obj.push_back(Pair("spendVout",(int)txin.prevout.n));
+          CTxDestination filterAddress = DecodeDestination(strAddress);
+          if (address == tAddress || !filterByAddress) {
+            filteredSpends += CAmount(-parentOut.nValue);
+            tSpends.push_back(obj);
+          }
+        }
+      }
+    }
+  }
+  spends.push_back(Pair("transparentSpends",tSpends));
+
+  // Sapling Inputs belonging to the wallet
+  UniValue zsSpends(UniValue::VARR);
+  if (isZsAddress || !filterByAddress) {
+    for (int i = 0; i < wtx.vShieldedSpend.size(); i++) {
+      shieldedSpendCount++;
+      const SpendDescription& spendDesc = wtx.vShieldedSpend[i];
+      UniValue obj(UniValue::VOBJ);
+
+      SaplingOutPoint op = pwalletMain->mapSaplingNullifiersToNotes[spendDesc.nullifier];
+
+      if (pwalletMain->IsSaplingNullifierFromMe(spendDesc.nullifier)) {
+        const CWalletTx* parent = pwalletMain->GetWalletTx(pwalletMain->mapSaplingNullifiersToNotes[spendDesc.nullifier].hash);
+        const OutputDescription& output = parent->vShieldedOutput[op.n];
+        auto nd = pwalletMain->mapWallet[pwalletMain->mapSaplingNullifiersToNotes[spendDesc.nullifier].hash].mapSaplingNoteData[op];
+        auto pt = libzcash::SaplingNotePlaintext::decrypt(output.encCiphertext,nd.ivk,output.ephemeralKey,output.cm);
+
+        if (pt) {
+          auto note = pt.get();
+          auto pa = nd.ivk.address(note.d);
+          auto address = pa.get();
+          shieldedSpendsSpentCount++;
+          totalSpends += CAmount(-note.value());
+          obj.push_back(Pair("address",EncodePaymentAddress(address)));
+          obj.push_back(Pair("amount", ValueFromAmount(CAmount(-note.value()))));
+          obj.push_back(Pair("spendTxid",parent->GetHash().ToString()));
+          obj.push_back(Pair("spendshieldedOutputIndex",(int)op.n));
+          if (address == zsAddress || !filterByAddress) {
+            filteredSpends += CAmount(-note.value());
+            zsSpends.push_back(obj);
+          }
+        }
+      }
+    }
+  }
+  spends.push_back(Pair("saplingSpends",zsSpends));
+
+ 
+  spends.push_back(Pair("totalSpends",ValueFromAmount(filteredSpends)));
+
+  if (!filterByAddress) {
+    if (filteredSpends != 0 && (vinCount != vinSpendCount || shieldedSpendCount != shieldedSpendsSpentCount)) {
+      spends.push_back(Pair("missingSpendingKeys", true));
+      spends.push_back(Pair("vinCount", vinCount));
+      spends.push_back(Pair("vinSpendCount", vinSpendCount));
+      spends.push_back(Pair("shieldedSpendCount", shieldedSpendCount));
+      spends.push_back(Pair("shieldedSpendsSpentCount", shieldedSpendsSpentCount));
+    } else {
+        spends.push_back(Pair("missingSpendingKeys", false));
+    }
+  }
+}
+
+void zsTxSendsToJSON(const CWalletTx& wtx, UniValue& sends, CAmount& totalSends, const std::string& strAddress, bool filterByAddress) {
+
+  LOCK2(cs_main, pwalletMain->cs_wallet);
+
+  //Used to identify incomplete key sets
+  int shieldedOutputCount = 0;
+  int shieldedOutputDecryptedCount = 0;
+
+  //Check address
+  bool isTAddress = false;
+  bool isZsAddress = false;
+
+  CTxDestination tAddress = DecodeDestination(strAddress);
+  auto zAddress = DecodePaymentAddress(strAddress);
+  SaplingPaymentAddress zsAddress;
+
+  if (filterByAddress) {
+
+    if (IsValidDestination(tAddress))
+      isTAddress = true;
+
+    if (IsValidPaymentAddress(zAddress)) {
+      if (boost::get<libzcash::SaplingPaymentAddress>(&zAddress) != nullptr) {
+          zsAddress = boost::get<libzcash::SaplingPaymentAddress>(zAddress);
+          isZsAddress = true;
+      }
+    }
+  }
+
+  //All Transparent Sends in the transaction
+
+  UniValue tSends(UniValue::VARR);
+  if (isTAddress || !filterByAddress) {
+    for (int i = 0; i < wtx.vout.size(); i++) {
+      const CTxOut& txout = wtx.vout[i];
+      UniValue obj(UniValue::VOBJ);
+      CTxDestination address;
+      ExtractDestination(txout.scriptPubKey, address);
+      obj.push_back(Pair("address",EncodeDestination(address)));
+      obj.push_back(Pair("scriptPubKey",HexStr(txout.scriptPubKey.begin(), txout.scriptPubKey.end())));
+      obj.push_back(Pair("amount",ValueFromAmount(-txout.nValue)));
+      obj.push_back(Pair("vout", i));
+      if (address == tAddress || !filterByAddress) {
+        totalSends += CAmount(-txout.nValue);
+        tSends.push_back(obj);
+      }
+    }
+  }
+  sends.push_back(Pair("transparentSends",tSends));
+
+  //All Shielded Sends in the transaction
+  UniValue zsSends(UniValue::VARR);
+  if (isZsAddress || !filterByAddress) {
+    for (int i = 0; i < wtx.vShieldedOutput.size(); i++) {
+      const OutputDescription& outputDesc = wtx.vShieldedOutput[i];
+      shieldedOutputCount++;
+      UniValue obj(UniValue::VOBJ);
+      bool changeTx = false;
+
+      //Decrypt sapling outgoing t to z transaction using HDseed
+      if (wtx.vShieldedSpend.size()==0) {
+        HDSeed seed;
+        if (pwalletMain->GetHDSeed(seed)) {
+          auto opt = libzcash::SaplingOutgoingPlaintext::decrypt(
+                  outputDesc.outCiphertext,ovkForShieldingFromTaddr(seed),outputDesc.cv,outputDesc.cm,outputDesc.ephemeralKey);
+
+          if (opt) {
+            auto opt_unwrapped = opt.get();
+            auto pt = libzcash::SaplingNotePlaintext::decrypt(
+                    outputDesc.encCiphertext,outputDesc.ephemeralKey,opt_unwrapped.esk,opt_unwrapped.pk_d,outputDesc.cm);
+
+            if (pt) {
+              shieldedOutputDecryptedCount++;
+              auto pt_unwrapped = pt.get();
+              libzcash::SaplingPaymentAddress sentAddr(pt_unwrapped.d, opt_unwrapped.pk_d);
+              obj.push_back(Pair("address",EncodePaymentAddress(sentAddr)));
+              obj.push_back(Pair("amount", ValueFromAmount(CAmount(pt_unwrapped.value()))));
+              obj.push_back(Pair("shieldedOutputIndex",i));
+              obj.push_back(Pair("change",false));
+              if (sentAddr == zsAddress || !filterByAddress) {
+                totalSends += CAmount(-pt_unwrapped.value());
+                zsSends.push_back(obj);
+              }
+            }
+          }
+        }
+
+      //attempt Decryption of Outgoing Sapling using wallet extended spending keys
+      } else {
+        std::set<libzcash::SaplingPaymentAddress> addresses;
+        pwalletMain->GetSaplingPaymentAddresses(addresses);
+        for (auto addr : addresses) {
+          libzcash::SaplingExtendedSpendingKey extsk;
+          if (pwalletMain->GetSaplingExtendedSpendingKey(addr, extsk)) {
+            auto opt = libzcash::SaplingOutgoingPlaintext::decrypt(
+                    outputDesc.outCiphertext,extsk.expsk.full_viewing_key().ovk,outputDesc.cv,outputDesc.cm,outputDesc.ephemeralKey);
+
+            if (opt) {
+              auto opt_unwrapped = opt.get();
+              auto pt = libzcash::SaplingNotePlaintext::decrypt(
+                      outputDesc.encCiphertext,outputDesc.ephemeralKey,opt_unwrapped.esk,opt_unwrapped.pk_d,outputDesc.cm);
+
+              if (pt) {
+                auto pt_unwrapped = pt.get();
+                auto memo = pt_unwrapped.memo();
+                shieldedOutputDecryptedCount++;
+                libzcash::SaplingPaymentAddress sentAddr(pt_unwrapped.d, opt_unwrapped.pk_d);
+                obj.push_back(Pair("address",EncodePaymentAddress(sentAddr)));
+                obj.push_back(Pair("amount", ValueFromAmount(CAmount(-pt_unwrapped.value()))));
+                obj.push_back(Pair("memo", HexStr(memo)));
+
+              if (memo[0] <= 0xf4) {
+                  auto end = std::find_if(memo.rbegin(), memo.rend(), [](unsigned char v) { return v != 0; });
+                  std::string memoStr(memo.begin(), end.base());
+                if (utf8::is_valid(memoStr)) {
+                obj.push_back(Pair("memoStr", memoStr));
+            }
+        }
+                obj.push_back(Pair("shieldedOutputIndex",i));
+
+                //Check Change Status
+                if (wtx.vShieldedSpend.size()!=0) {
+                  std::set<std::pair<PaymentAddress, uint256>> nullifierSet;
+                  nullifierSet = pwalletMain->GetNullifiersForAddresses({sentAddr});
+                  BOOST_FOREACH(const SpendDescription& spendDesc, wtx.vShieldedSpend) {
+                    if (nullifierSet.count(std::make_pair(sentAddr, spendDesc.nullifier))) {
+                        changeTx = true;
+                    }
+                  }
+                }
+                obj.push_back(Pair("change",changeTx));
+                if (sentAddr == zsAddress || !filterByAddress) {
+                  totalSends += CAmount(-pt_unwrapped.value());
+                  zsSends.push_back(obj);
+                }
+              }
+            }
+          }
+        }
+      }
+    }
+  }
+    sends.push_back(Pair("saplingSends",zsSends));
+
+  if (shieldedOutputCount != shieldedOutputDecryptedCount) {
+    sends.push_back(Pair("missingSaplingOVK", true));
+  } else {
+    sends.push_back(Pair("missingSaplingOVK", false));
+  }
+
+  sends.push_back(Pair("totalSends",ValueFromAmount(totalSends)));
+}
+
+void zsWalletTxJSON(const CWalletTx& wtx, UniValue& ret, const std::string strAddress, bool fBool, const int returnType) {
+
+  LOCK2(cs_main, pwalletMain->cs_wallet);
+
+  //Track total wallet spend and received
+  CAmount totalSpends = 0;
+  CAmount filteredSpends = 0;
+  CAmount totalReceived = 0;
+  CAmount totalSends = 0;
+
+  //Various Univalue to be added to the final transaction
+  UniValue spends(UniValue::VOBJ);
+  UniValue received(UniValue::VOBJ);
+  UniValue sends(UniValue::VOBJ);
+  UniValue tx(UniValue::VOBJ);
+
+  //Begin Compiling the Decrypted Transaction
+  tx.push_back(Pair("txid", wtx.GetHash().ToString()));
+  if (wtx.IsCoinBase())
+  {
+      tx.push_back(Pair("coinbase", true));
+      if (wtx.GetDepthInMainChain() < 1)
+          tx.push_back(Pair("category", "orphan"));
+      else if (wtx.GetBlocksToMaturity() > 0)
+          tx.push_back(Pair("category", "immature"));
+      else
+          tx.push_back(Pair("category", "generate"));
+  } else {
+    tx.push_back(Pair("coinbase", false));
+    tx.push_back(Pair("category", "standard"));
+  }
+
+  tx.push_back(Pair("blockhash", wtx.hashBlock.GetHex()));
+  tx.push_back(Pair("blockindex", wtx.nIndex));
+  int confirms = wtx.GetDepthInMainChain();
+  if(confirms > 0)
+  {
+      tx.push_back(Pair("blocktime", mapBlockIndex[wtx.hashBlock]->GetBlockTime()));
+  } else {
+      tx.push_back(Pair("blocktime", 0));
+  }
+  tx.push_back(Pair("expiryheight", (int64_t)wtx.nExpiryHeight));
+  tx.push_back(Pair("confirmations", confirms));
+  tx.push_back(Pair("time", wtx.GetTxTime()));
+  tx.push_back(Pair("size", static_cast<uint64_t>(GetSerializeSize(static_cast<CTransaction>(wtx), SER_NETWORK, PROTOCOL_VERSION))));
+
+  //Wallet Conflicts
+  UniValue conflicts(UniValue::VARR);
+  BOOST_FOREACH(const uint256& conflict, wtx.GetConflicts())
+      conflicts.push_back(conflict.GetHex());
+  tx.push_back(Pair("walletconflicts", conflicts));
+
+  // Return Type used to determine what is included in the transaction
+  // 0 Spends, Received and spends
+  // 1 Sends
+  // 2 Received
+  // 3 Spends
+  // TODO - Setup Enum, maybe...
+
+  // Add Spends retrieved earlier
+  if (returnType != 2) {
+    zsTxSpendsToJSON(wtx, spends, totalSpends, filteredSpends, strAddress, fBool);
+    if ((!fBool || filteredSpends != 0) && (returnType == 0 || returnType == 1)) {
+      tx.push_back(Pair("spends",spends));
+    }
+   }
+  
+
+  // Get Sends
+  if (returnType == 0 || returnType == 3) {
+    //Only include sends if there are spends that belong to the wallet.
+    if (totalSpends != 0 || fBool) {
+      zsTxSendsToJSON(wtx, sends, totalSends, strAddress, fBool);
+    }
+    if (!fBool || totalSends != 0) {
+      tx.push_back(Pair("sends",sends));
+    }
+  }
+
+  if ((returnType == 0 && (!fBool || filteredSpends != 0 || totalSends != 0))
+   || (returnType == 1 && (!fBool || filteredSpends != 0))
+   || (returnType == 2 && (!fBool || totalSends != 0))) {
+    ret.push_back(tx);
+  }
+}
+
+UniValue z_listsentbyaddress(const UniValue& params, bool fHelp,const CPubKey&) {
+  if (!EnsureWalletIsAvailable(fHelp))
+      return NullUniValue;
+
+  if (fHelp || params.size() > 5 || params.size() == 3)
+      throw runtime_error(
+        "z_listsentbyaddress\n"
+        "\nReturns decrypted Hush outputs sent to a single address.\n"
+        "\n"
+        "This function only returns information on addresses sent from wallet addresses with full spending keys."
+        "\n"
+        "\nArguments:\n"
+        "1. \"hushaddress:\"            (string, required) \n"
+        "\n"
+        "2. \"Minimum Confimations:\"   (numeric, optional, default=0) \n"
+        "\n"
+        "3. \"Filter Type:\"            (numeric, optional, default=0) \n"
+        "                               Value of 0: Returns all transactions in the wallet\n"
+        "                               Value of 1: Returns the last x days of transactions\n"
+        "                               Value of 2: Returns transactions with confimations less than x\n"
+        "\n"
+        "4. \"Filter:\"                 (numeric, optional, default=999999) \n"
+        "                               Filter Type equal 0: paramater ignored\n"
+        "                               Filter Type equal 1: number represents the number of days returned\n"
+        "                               Filter Type equal 2: number represents the max confirmations for transaction to be returned\n"
+        "\n"
+        "5. \"Count:\"                 (numeric, optional, default=9999999) \n"
+        "                               Last n number of transactions returned\n"
+        "\n"
+        "Default Parameters:\n"
+        "2. 0 - O confimations required\n"
+        "3. 0 - Returns all transactions\n"
+        "4. 9999999 - Ignored\n"
+        "5. 9999999 - Return the last 9,999,999 transactions.\n"
+        "\n"
+        "\nResult:\n"
+        "   \"txid\":  \"transactionid\",           (string) The transaction id.\n"
+        "   \"coinbase\": \"coinbase\",             (string) Coinbase transaction, true or false\n"
+        "   \"category\": \"category\",             (string) orphan (coinbase), immature (coinbase), generate (coinbase), regular\n"
+        "   \"blockhash\": \"hashvalue\",           (string) The block hash containing the transaction\n"
+        "   \"blockindex\": n,                    (numeric) The block index containing the transaction\n"
+        "   \"blocktime\": n,                     (numeric) The block time in seconds of the block containing the transaction, 0 for unconfirmed transactions\n"
+        "   \"expiryheight\": n,                  (numeric) The expiry height of the transaction\n"
+        "   \"confirmations\": n,                 (numeric) The number of confirmations for the transaction\n"
+        "   \"time\": xxx,                        (numeric) The transaction time in seconds of the transaction\n"
+        "   \"size\": xxx,                        (numeric) The transaction size\n"
+        "   \"walletconflicts\": [conflicts],     An array of wallet conflicts\n"
+        "   \"sends\": {                          A list of outputs of where funds were sent to in the transaction,\n"
+        "                                         only available if the transaction has valid sends (inputs) belonging to the wallet\n"
+        "       \"transparentSends\": [{              An Array of spends (outputs) for transparent addresses of the receipient\n"
+        "           \"address\": \"hushaddress\",         (string) Hush transparent address (t-address)\n"
+        "           \"scriptPubKey\": \"script\",         (string) Script for the Hush transparent address (t-address)\n"
+        "           \"amount\": x.xxxx,                 (numeric) Value of output being sent " + CURRENCY_UNIT + ", negative for sends\n"
+        "           \"vout\": : n,                      (numeric) the vout value\n"
+        "       }],\n"
+        "       \"saplingSends\": [{                 An Array of spends (outputs) for sapling addresses\n"
+        "           \"address\": \"hushaddress\",         (string) Hush sapling address (z-address) of the receipient\n"
+        "           \"amount\": x.xxxx,                 (numeric) Value of output being sent" + CURRENCY_UNIT + ", negative for sends\n"
+        "           \"memo\": xxxxx,            (string) hexademical string representation of memo field\n"
+        "           \"memoStr\" : \"memo\",             (string) Only returned if memo contains valid UTF-8 text.\n"
+        "           \"shieldedOutputIndex\": n,         (numeric) The index of the ShieledOutput\n"
+        "           \"change\": true/false              (string) The note is change. This can result from sending funds\n"
+        "                                                        to the same address they came from, or incomplete useage\n"
+        "                                                        resulting in the remainder of the note used being sent back to the\n"
+        "                                                        same z-address.\n"
+        "       }],\n"
+        "       \"missingSaplingOVK\": true/false    (string) True if the sapling outputs are not decryptable\n"
+        "   }\n"
+        "\nExamples:\n"
+        + HelpExampleCli("z_listsentbyaddress", "t1KzZ5n2TPEGYXTZ3WYGL1AYEumEQaRoHaL")
+        + HelpExampleRpc("z_listsentbyaddress", "t1KzZ5n2TPEGYXTZ3WYGL1AYEumEQaRoHaL")
+    );
+
+    LOCK2(cs_main, pwalletMain->cs_wallet);
+
+    UniValue ret(UniValue::VARR);
+
+    //param values`
+    int64_t nMinConfirms = 0;
+    int64_t nFilterType = 0;
+    int64_t nFilter = 9999999;
+    int64_t nCount = 9999999;
+
+    if (params.size() >= 2)
+      nMinConfirms = params[1].get_int64();
+
+    if (params.size() >= 4) {
+      nFilterType = params[2].get_int64();
+      nFilter = params[3].get_int64();
+    }
+
+    if (params.size() == 5) {
+      nCount = params[4].get_int64();
+    }
+
+    if (nMinConfirms < 0)
+      throw runtime_error("Minimum confimations must be greater that 0");
+
+    if (nFilterType < 0 || nFilterType > 2)
+        throw runtime_error("Filter type must be 0, 1 or 2.");
+
+    if (nFilter < 0)
+        throw runtime_error("Filter must be greater that 0.");
+
+    //Created Ordered Transaction Map
+    map<int64_t,CWalletTx> orderedTxs;
+    for (map<uint256, CWalletTx>::iterator it = pwalletMain->mapWallet.begin(); it != pwalletMain->mapWallet.end(); ++it) {
+      const CWalletTx& wtx = (*it).second;
+      orderedTxs.insert(std::pair<int64_t,CWalletTx>(wtx.nOrderPos, wtx));
+    }
+
+
+    uint64_t t = GetTime();
+    //Reverse Iterate thru transactions
+    for (map<int64_t,CWalletTx>::reverse_iterator it = orderedTxs.rbegin(); it != orderedTxs.rend(); ++it) {
+      const CWalletTx& wtx = (*it).second;
+
+      if (!CheckFinalTx(wtx))
+          continue;
+
+      if (wtx.GetDepthInMainChain() < 0)
+          continue;
+
+      if (wtx.mapSaplingNoteData.size() == 0 && !wtx.IsTrusted())
+          continue;
+
+      //Excude transactions with less confirmations than required
+      if (wtx.GetDepthInMainChain() < nMinConfirms)
+          continue;
+
+      //Exclude Transactions older that max days old
+      if (wtx.GetDepthInMainChain() > 0 && nFilterType == 1 && mapBlockIndex[wtx.hashBlock]->GetBlockTime() < (t - (nFilter * 60 * 60 * 24)))
+          continue;
+
+      //Exclude transactions with greater than max confirmations
+      if (nFilterType == 2 && wtx.GetDepthInMainChain() > nFilter)
+          continue;
+
+      zsWalletTxJSON(wtx, ret, "*", false, 0);
+
+      if (ret.size() >= nCount) break;
+    }
+
+    vector<UniValue> arrTmp = ret.getValues();
+
+    std::reverse(arrTmp.begin(), arrTmp.end()); // Return oldest to newest
+
+    ret.clear();
+    ret.setArray();
+    ret.push_backV(arrTmp);
+
+    return ret;
+}
+
+static const CRPCCommand commands[] =
+{   //  category              name                          actor (function)              okSafeMode
+    //  --------------------- ------------------------      -----------------------       ----------
+    {   "Hush Exclusive",     "z_listsentbyaddress",      &z_listsentbyaddress,      true },
+};
+
+void RegisterHushExclusiveRPCCommands(CRPCTable &tableRPC)
+{
+    for (unsigned int vcidx = 0; vcidx < ARRAYLEN(commands); vcidx++)
+        tableRPC.appendCommand(commands[vcidx].name, &commands[vcidx]);
+}

src/wallet/rpchushwallet.h

@@ -0,0 +1,28 @@
+// Copyright (c) 2016 The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+#ifndef BITCOIN_WALLET_RPCHUSHWALLET_H
+#define BITCOIN_WALLET_RPCHUSHWALLET_H
+
+struct balancestruct {
+  CAmount confirmed;
+  CAmount unconfirmed;
+  CAmount locked;
+  CAmount immature;
+};
+
+void zsTxSpendsToJSON(const CWalletTx& wtx, UniValue& spends, CAmount& totalSpends, CAmount& filteredSpends, const std::string& strAddress, bool filterByAddress);
+void zsTxSendsToJSON(const CWalletTx& wtx, UniValue& sends, CAmount& totalSends, const std::string& strAddress, bool filterByAddress);
+void zsWalletTxJSON(const CWalletTx& wtx, UniValue& ret, const std::string strAddress, bool fBool, const int returnType);
+
+
+class CRPCTable;
+
+void RegisterHushExclusiveRPCCommands(CRPCTable &tableRPC);
+
+
+
+
+
+#endif //BITCOIN_WALLET_RPCWALLET_H