Commit Graph

10632 Commits

Author SHA1 Message Date
Jack Grigg
f86111d3f5 Disable building Proton in Gitian
This is the patch used to build 1.0.9 and 1.0.10.

Part of #2404.
2017-06-23 01:02:01 +12:00
Homu
d52ac0d498 Auto merge of #2461 - str4d:release-v1.0.10, r=str4d
Release v1.0.10
2017-06-21 20:40:11 -07:00
Jack Grigg
5073467dad Move temporary release notes to final ones 2017-06-22 15:23:02 +12:00
Jack Grigg
93a63765b6 make-release.py: Updated release notes and changelog for 1.0.10. 2017-06-22 15:13:04 +12:00
Jack Grigg
c04ffa0e32 make-release.py: Updated manpages for 1.0.10. 2017-06-22 15:05:04 +12:00
Jack Grigg
dc2ead6021 make-release.py: Versioning changes for 1.0.10. 2017-06-22 14:47:15 +12:00
Homu
59de56eeca Auto merge of #2342 - bitcartel:1081__mempoolpatch, r=str4d
Add ability for node to reject tx from mempool by number of tx inputs

Implement short-term solution described in #2343 so that users can respond promptly to critical short-term problems caused by quadratic validation scaling, such as the getblocktemplate latency, block propagation latency, and mempool size inflation issues described in #2333.
2017-06-21 14:42:13 -07:00
Jack Grigg
6ea58d1531 Use sendfrom for both t-addr calls 2017-06-22 09:34:10 +12:00
Homu
02e5fffadc Auto merge of #2360 - daira:2359.remove-lax-der-validation, r=arcalinea
Remove unneeded lax ECDSA signature verification

Fixes #2359. Removes code for lax ECDSA verification, and the SCRIPT_VERIFY_DERSIG flag that controlled it. The behaviour is as-if the flag is always set.
2017-06-20 19:05:58 -07:00
Simon
99f6d5da6c Fix #b1eb4f2 so test checks sendfrom as originally intended.
Also reduce number of z_sendmany calls made so test runs quicker.
2017-06-20 22:49:47 +00:00
Daira Hopwood
193b3e8b28 Delete test that is redundant and inapplicable to Zcash.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-20 10:03:17 +01:00
Homu
c050b99469 Auto merge of #2456 - btccom:master, r=str4d
[mining] let "getblocktemplate" work when disable wallet

we already support GetBlockTemplate without build wallet, see:

https://github.com/zcash/zcash/blob/master/src/rpcmining.cpp

```
    // Wallet or miner address is required because we support coinbasetxn
    if (GetArg("-mineraddress", "").empty()) {
#ifdef ENABLE_WALLET
        if (!pwalletMain) {
            throw JSONRPCError(RPC_METHOD_NOT_FOUND, "Wallet disabled and -mineraddress not set");
        }
#else
        throw JSONRPCError(RPC_METHOD_NOT_FOUND, "zcashd compiled without wallet and -mineraddress not set");
#endif
    }
```

so the macro should be removed from `src/rpcserver.cpp`, otherwise you can't call `getblocktemplate` when you disable wallet.
2017-06-20 01:15:15 -07:00
Jack Grigg
b1eb4f251a Fix comment 2017-06-20 19:54:11 +12:00
Homu
00fd23930b Auto merge of #2443 - str4d:1621-priority-download-path, r=str4d
Rename FALLBACK_DOWNLOAD_PATH to PRIORITY_DOWNLOAD_PATH

Closes #1621.
2017-06-19 23:46:44 -07:00
Simon
d8616d012a Partial revert & fix for commit 9e84b5a ; code block in wrong location. 2017-06-19 21:11:34 -07:00
Jack Grigg
4ef014151d Additional testing of -mempooltxinputlimit 2017-06-20 15:58:46 +12:00
Kevin Pan
26d27a15ce "getblocktemplate" could work without wallet 2017-06-20 10:41:46 +08:00
Daira Hopwood
c2a722d3c4 Fix a comment that was made stale before launch by #1016 (commit 542da61).
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-19 16:33:18 +01:00
Daira Hopwood
00fde35b1c Make transaction test failures print the comments preceding the test JSON.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-19 16:33:18 +01:00
Daira Hopwood
4a785b0a5b Repair tests for strict DER signatures.
While we're at it, repair a similar test for CLTV, and make the repaired RPC tests run by default.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-19 16:32:15 +01:00
Simon
9e84b5aa0d Check mempooltxinputlimit when creating a transaction to avoid local
mempool rejection.
2017-06-17 14:41:25 -07:00
Daira Hopwood
de609b8c54 Strict DER signatures are always enforced; remove the flag and code that used it.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-17 17:19:08 +01:00
Daira Hopwood
3c985d26ce Remove unneeded lax ECDSA signature verification.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-17 17:19:08 +01:00
Homu
ef24e8e6be Auto merge of #2335 - str4d:2333-validation-speed, r=str4d
Switch to libsecp256k1-based validation for ECDSA

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6983
- bitcoin/bitcoin#6954

Part of #2333.
2017-06-17 07:18:25 -07:00
Jack Grigg
b661736b87 Hold an ECCVerifyHandle in zcash-gtest 2017-06-18 02:15:05 +12:00
Jack Grigg
5799c5f8c0 Add test for -mempooltxinputlimit 2017-06-17 14:59:16 +12:00
Simon
da6d93916d Add option 'mempooltxinputlimit' so the mempool can reject a transaction
based on the number of transparent inputs.
2017-06-16 19:31:33 -07:00
Homu
d5934e9268 Auto merge of #2436 - kozyilmaz:multipath, r=str4d
support per platform filename and hash setting for dependencies

added to support per-platform Rust packages, tested on macOS Sierra 10.12.5 and Ubuntu 16.04 LTS (issue #2431)
2017-06-16 18:03:42 -07:00
Jack Grigg
fd0d1c7d60 Ensure that ECDSA constant sizes are correctly-sized 2017-06-17 12:10:15 +12:00
Jack Grigg
1f5941062a Remove redundant = 0 initialisations 2017-06-17 12:10:14 +12:00
Jack Grigg
877964c82f Specify ECDSA constant sizes as constants 2017-06-17 12:10:14 +12:00
Jack Grigg
f16175471a Update Debian copyright list 2017-06-17 12:10:13 +12:00
Jack Grigg
c032f1b687 Add comments 2017-06-17 12:09:44 +12:00
Homu
dfa4ed19bb Auto merge of #2440 - bitcartel:1360_reduce_info_leakage_vpub_new, r=str4d
Fix intermediate vpub_new leakage in multi joinsplit tx

Resolves information leakage discussed here https://github.com/zcash/zcash/issues/1360#issuecomment-284561331

Example output in debug.log showing how intermediate vpub_new is now 0
https://gist.github.com/bitcartel/86ca316b74f0b1ec6d8de3ac132006da

When reviewing, note that the indentation of a large chunk of code (scenario 3 part 2) changed, so use `git diff -w` (or similar) or append `?w=1` to the Github URL e.g. https://github.com/zcash/zcash/pull/2440/files?w=1
2017-06-15 21:33:01 -07:00
Homu
3440de74ee Auto merge of #2386 - str4d:2385-consensus-correction, r=str4d
Correct consensus logic in ContextualCheckInputs

Closes #2385.
2017-06-15 18:50:03 -07:00
Jack Grigg
30006a2e79 Correct consensus logic in ContextualCheckInputs
Closes #2385.
2017-06-16 13:45:19 +12:00
Jack Grigg
1b786a93c3 Add test for incorrect consensus logic 2017-06-16 13:45:14 +12:00
Homu
0a80a1cea3 Auto merge of #2227 - str4d:2074-ignore-virtual-cores, r=str4d
Use real number of cores, ignore virtual cores

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6361
- bitcoin/bitcoin#6370

Part of #2074.
2017-06-15 17:05:02 -07:00
Homu
6189c70caa Auto merge of #1747 - str4d:fix-spendingkey-locking, r=str4d
Fix incorrect locking in CCryptoKeyStore
2017-06-15 16:02:07 -07:00
Homu
35bf9e73ff Auto merge of #2420 - kozyilmaz:disable-libs, r=str4d
option to disable building libraries (zcutil/build.sh)

option to disable building libraries (zcutil/build.sh)
2017-06-15 07:31:46 -07:00
Jack Grigg
be60c6d7f6 Rename FALLBACK_DOWNLOAD_PATH to PRIORITY_DOWNLOAD_PATH
Closes #1621.
2017-06-15 16:32:36 +12:00
Simon
c93a0872e8 Fix intermediate vpub_new leakage in multi joinsplit tx (#1360) 2017-06-13 23:21:53 -07:00
Homu
a23fdf862d Auto merge of #2245 - daira:2244.remove-old-peer-workarounds, r=str4d
Delete old protocol version constants and simplify code that used them.

fixes #2244

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-13 23:10:19 -07:00
Homu
0ecd0642e1 Auto merge of #2412 - kozyilmaz:linker, r=str4d
[macOS] system linker does not support “--version” option but only “-v”

To build Zcash on macOS Sierra I use a self-built gcc-6.3/g++-6.3 but macOS linker (/usr/bin/ld). macOS linker does not support “--version” option but “-v”

On Ubuntu 16.04
```
$ ld --version
GNU ld (GNU Binutils for Ubuntu) 2.26.1
Copyright (C) 2015 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) a later version.
This program has absolutely no warranty.
$ ld -v
GNU ld (GNU Binutils for Ubuntu) 2.26.1
```

On macOS Sierra
```
$ ld --version
ld: unknown option: --version
$ ld -v
@(#)PROGRAM:ld  PROJECT:ld64-278.4
configured to support archs: armv6 armv7 armv7s arm64 i386 x86_64 x86_64h armv6m armv7k armv7m armv7em (tvOS)
LTO support using: LLVM version 8.1.0, (clang-802.0.42)
TAPI support using: Apple TAPI version 1.33.11
```
2017-06-13 20:16:13 -07:00
Homu
992abfac6f Auto merge of #2429 - hajdbo:master, r=daira
documentation z_validateaddress was missing param
2017-06-09 14:48:28 -07:00
kozyilmaz
e6dc07bc69 support per platform filename and hash setting for dependencies 2017-06-09 13:15:27 +03:00
Boris Hajduk
8a38e6c1d0 documentatin z_validateaddress was missing param 2017-06-07 15:49:49 +08:00
Jack Grigg
50fa079748 Fix potential overflows in ECDSA DER parsers 2017-06-06 20:08:03 +12:00
Pieter Wuille
3d02d0f63a Switch to libsecp256k1-based validation for ECDSA 2017-06-06 17:52:25 +12:00
Pieter Wuille
c1afe40a17 Update key.cpp to new secp256k1 API 2017-06-06 17:50:22 +12:00