fix(wallet): always flag a user-started consolidation as manual

startConsolidation reset the shared ConsolidationRun but never cleared
auto_consolidate_run_. In the rare window where a background auto cycle was torn
down by a disconnect (abort) before pumpAutoConsolidation cleared its flag, a
user-started run could inherit the stale flag and be treated as an auto cycle —
silent (no merge-done/failed toasts) and auto-dismissed. Clear the flag on a
successful manual start so a user run always keeps its own notifications and
lifecycle. No behavior change in the normal case. Build + tests green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
2026-10-26 14:05:47 -05:00
co-authored by Claude Opus 4.8
parent 112752e8af
commit 9335e2bffb
+2
View File
@@ -6224,6 +6224,8 @@ bool App::startConsolidation(const std::vector<services::NoteGroup>& groups, dou
n.warning(TR("merge_keep_each_select"));
return false;
}
auto_consolidate_run_ = false; // a user-started run is never treated as a silent auto cycle, even if an
// auto run was torn down (abort) with its flag not yet cleared
n.success(TR("merge_started"));
return true; // syncing, the lock, a busy node and pending sends are the run's own pauses
}